On 08/11/2016 03:13 PM, Dimitry Sibiryakov wrote:
>     Hello, All.
>
>     If posix/os_utils.cpp I see following code:
>
>> // force file descriptor to have O_CLOEXEC set
>> int open(const char* pathname, int flags, mode_t mode)
>> {
>>      int fd;
>>      fd = openFile(pathname, flags | O_CLOEXEC, mode);
>>
>>      if (fd < 0 && errno == EINVAL)  // probably O_CLOEXEC not accepted
>>              fd = openFile(pathname, flags | O_CLOEXEC, mode);
>>
>>      setCloseOnExec(fd);
>>      return fd;
>> }
>     Shouldn't second call of openFile have "flags & ~O_CLOEXEC" parameter, 
> because in
> current form it doesn't differ from the first call and has to fail as well?..
>

Thanks fixed.
Luckily this flags does not work only for old kernels (<= 2.6.23) which 
are anyway not recommended for running FB3 and hard to find in the real 
world, therefore I do not mention this in the tracker.



------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity 
planning reports. http://sdm.link/zohodev2dev
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel

Reply via email to