On Thu, 23 Mar 2017 16:05:57 +0100 Dimitry Sibiryakov wrote > 23.03.2017 15:58, Alex Peshkoff wrote: > > Occasionally BuildExecutableInstall.bat itself was wrongly > > committed to git - checked outon linux it has CR-LF lineend instead > > just LF. I.e. itself needs unix2dos ;) Luckily it does not actually > > matter. > > Actually, it does matter. Stupid Windows command line processor > works with "LF-only" files incorrectly. And because git's default > for .cmd files is "checkout as is", it must be kept in repository > with "CR-LF" EOL mark. >
In this case the correct solution would be to commit .cmd files with CRLF eols. The packaging script only started needing to use unix2dos after the move to git because we cannot force the eol in text files that are used across different platforms. But we didn't discover this until late in the RC stage of v3.0.0, hence a rapid fix with unix2dos. Paul -- Paul Reeves http://www.ibphoenix.com Supporting users of Firebird ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
