On 05/12/17 15:33, marius adrian popa wrote:
> Also in firebird/extern/cloop/src/tests/test1/CTest.c

The simplest fix is to disable tests on mac

> related to this patch
> https://gerrit.libreoffice.org/#/c/37488/6/external/firebird/firebird-macosx.patch.1
>
> these lines and changes are still needed for osx
>
>   #include "CalcCApi.h"
> -#include <malloc.h>
> +#include <stdlib.h>
>   #include <stdio.h>
>
> now build fails
> https://ci.libreoffice.org/job/lo_gerrit/11317/Config=macosx_clang_dbgutil/
>
> On Fri, May 12, 2017 at 1:10 PM, Tomaž Vajngerl <qui...@gmail.com> wrote:
>
>> Hi,
>>
>> On Fri, May 12, 2017 at 11:05 AM, marius adrian popa <map...@gmail.com>
>> wrote:
>>> Known issue in Firebird 3.0.x
>>>
>>> http://firebird.1100200.n4.nabble.com/std-c-11-added-to-
>> CXXFLAGS-in-3-0-on-linux-td4645224.html
>>> introduced by this commit
>>>
>>> https://github.com/FirebirdSQL/firebird/commit/52d9a05a0f3d
>>>
>> They would need to add something like "%/CRC32C.o: COMMON_FLAGS +=
>> -msse4" to prefix.darwin too (clang should have compatible switches)
>>
>> For Windows It is complicated as it depends if the particular VS
>> version supports the instructions or not, but you need to add some
>> compile switch too...
>>
>> That's only for compiler - in addition you also need run-time
>> detection, but I see this is already covered by SSE4_2Supported()
>> method.
>>
>> Regards, Tomaž
>>
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>
>
> Firebird-Devel mailing list, web interface at 
> https://lists.sourceforge.net/lists/listinfo/firebird-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel

Reply via email to