On 13-2-2019 00:26, Adriano dos Santos Fernandes wrote:
On 02/02/2019 12:09, Mark Rotteveel wrote:
In the Firebird sources, TimeZoneUtil::MAX_LEN is defined as 32, however
the column RDB$TIME_ZONES.RDB$TIME_ZONE_NAME is defined as CHAR(63).
There currently is one time zone name with length 32 (the rest is
shorter), so right now there is no problem, however this inconsistency
between definitions seems like an accident waiting to happen if in the
future a zone is added with a length longer than 32.
Could this be fixed so they both use the same length (I'd suggest 63)?
Then ISQL will also use it and will make it difficult to work there with
each time zone name taking so much space.
You already have that when selecting from the RDB$TIME_ZONES table though.
But more importantly, what will happen if a zone with a longer name is
introduced in the future? Will things break (or worse, cause overflow)?
Mark
--
Mark Rotteveel
Firebird-Devel mailing list, web interface at
https://lists.sourceforge.net/lists/listinfo/firebird-devel
