Hi *,
there was a lot of thoughts about FbScript class in last,
months/years. Today I was going thru some of the ideas and I decided,
we need to polish this code a little bit. So I started with ctor and I
did couple of changes in my private tree. I want to *hear your
opinions*, because the changes are breaking.
1. Only one constructor, taking string.
- the FbScript internally works with string so why bother with something else
2. Static method LoadFromFile returning instance
- following pattern in some classes in BCL
- it's better to state, we're actually reading the file now - in
ctor you don't know whether the file is read there or later when
needed
3. No ctor using TextReader.
- we have the string ctor now and this ctor was just simply reading
the whole content, so no benefit having it there, anybody can do it
yourself and know what (s)he is doing
I've changed couple of my apps to this new model to see whether it
fits better or generates a lot of changes etc. In my POV I see the new
code nicer, though the steps are almost same.
Note: This change will be part of 2.6. version.
--
Jiri {x2} Cincura (CTO x2develop.com)
http://blog.cincura.net/ | http://www.ID3renamer.com
------------------------------------------------------------------------------
_______________________________________________
Firebird-net-provider mailing list
Firebird-net-provider@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/firebird-net-provider
