On Thu, 15 Dec 2005, James Vega wrote:
> Axel,
>
> Attached is a simplistic patch to fix a problem with builtin_source. If
> one attempts to ". some_directory", fish will get stuck in an infinite
> loop. This patch requires a normal file as an argument. It would
> probably be better to still allow symbolic links as long as they point
> to an actual file, but this at least puts a band-aid over the immediate
> problem.
>
> James
> --
> GPG Key: 1024D/61326D40 2003-09-02 James Vega <[EMAIL PROTECTED]>
>
I've added another patch that makes sure that read errors aren't
ignored, so that future issues of this type should fail with a
semi-relevant error message instead of getting stuck in an infinite
loop.
I simply hadn't thought about the fact that a call to open() on a
directory won't fail, so I was a bit careless with checking errors on
already open file descriptors.
--
Axel
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Fish-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fish-users
