On 3/13/06, Nick Pilon <[EMAIL PROTECTED]> wrote: > On 3/12/06, James Vega <[EMAIL PROTECTED]> wrote: > > This has been brought up before and I didn't comment, but I don't think > > Axel should be adding a bunch of directories to the default path just > > because various systems may have software installed there. > > You don't have to. You can tell what system you're running on and > which directories actually exist, and decide what to add to the path > based on that. Any OS X system running fish will have software > installed in /sw/bin, as fish requires fink on OS X. Most will also > probably have software from darwinports in /opt/local/bin. > > > This seems > > more like something that should be done by the user in ~/.fish or > > possibly by the sysadmin in the system-wide fish file.
On Linux yes. On OS X, where almost everybody who use fish are _very_ likely to use e.g fink as well, it makes perfect sense to add this. Note that this check only takes place when running configure, meaning that if your build machine doesn't have these directories than neither will your package when running a packaer, so this will not result in unpredictable behaviour on client machines. > > It can't be done in ~/.fish, because that gets executed too late. We > shouldn't rely on the sysadmin doing it, especially when the locations > are standardized and the errors produced when something goes wrong are > so odd. > > > What I think > > makes the most sense is for the directories that are most commonly > > available and populated (/bin, /usr/bin, /usr/X11R6/bin and when root > > /sbin, /usr/sbin) should be in the default path. > > Which means /sw/bin and /opt/local/bin should be on OS X, as those are > the directories where the two common Unix software installers for that > platform put their binaries. This should already be happening. the configure script checks for the existance of /sw/bin, /opt/bin , /usr/pkg/bin and /opt/local/bin, and adds any of these that exist to the variable @[EMAIL PROTECTED] The etc/fish.in (which becomes /etc/fish) contains a segment of code that adds all known suitable directories to the path, and this includes any variables in @optbindir@, and if you are root, this also includes /sbin and /usr/sbin. I tested it and it works perfectly on my system. Could you try to diagnose what exactly goes wrong on OS X so that this doesn't work? > > -- > -Nick Pilon > -- Axel ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid0944&bid$1720&dat1642 _______________________________________________ Fish-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/fish-users
