On 11/17/06, Axel Liljencrantz <[EMAIL PROTECTED]> wrote: > Hi Netocrat, > > Long time, no see. > > On 11/17/06, Netocrat <[EMAIL PROTECTED]> wrote: > > Recently I noticed that on some tokens, pressing Alt-Up "hang"s the > > shell: it's not quite a hang because it eventually (minutes later) > > recovers. I tracked it down to the recursion in handle_token_history() > > in reader.c. The patch below allows ctrl-c to break out of the delay; I > > didn't more closely analyse the cause but this is a simple and effective > > workaround: > > It's amazing how much faster computers become. My desktop machine has > a ~2 GHz CPU, and a token search takes at most three or four seconds > when the only matching token is at the very beginning of the history. > On my 300 MHz server, the same search takes ~10 minutes. The strange > thing is that the performance difference seems to be significantly > larger than the difference in clock frequency would imply. I was under > the impression that instructions per clock, as well as memory speeds, > have not scaled in proportion to increased clock speeds. Perhaps the > working set of token search fits into the cache of the faster CPU, but > not into the smaller cache of the slower CPU? > > Whatever the cause, this is not acceptable, I'll have to look into > improving the token search. It is one of the uglier bits of fish code, > so it could use the cleanup.
I haven't cleaned anything up, but I kludged in a fast path. A worst case search on a large file has gone form ten minutes to one second on a 300 MHz system. [...] -- Axel ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Fish-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/fish-users
