On 2/2/07, Velko Hristov <[EMAIL PROTECTED]> wrote: > Hi, > > this is the updated version for the completions for vi/vim. They can be > cleaned up and generalized further (especially the functions > __fish_filter_text_files and __fish_filter_gzip_files can be replaced > by a function which takes the pattern as argument) so there is room > for improvement.
I've looked through the completions and I've made a small number of minor changes. Like I said in another email yesterday, the -f switch for mimedb will speed up mimedb calls considerably, so I've made this change. Your code needed improvement here since it was based on my bad advice. :-/ Like you suggested, I have replaced both __fish_filter functions with a generic one that takes a mimetype (possibly containing wildcards) as the first argument. I called the function __fish_filter_mime. I have also moved this filtering function to it's own file, since it seems to me that it is a useful general purpose function. I suspect will be used more in the future. I have also moved the gzip file completion out of __fish_complete_text into the vi/vim completion list, since __fish_complete_text seems like a good general purpose function to be used by other command specific completions, but gzip completions don't really fit in. With thes minor changes, I think that the vim completions look good, and the new functions should be useful for various other completions as well. The patch is in the darcs tree. [...] > Regards - Velko -- Axel ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Fish-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/fish-users
