On Fri, Nov 5, 2010 at 11:51 PM, David Frascone <[email protected]> wrote: > Done -- there's a new merge request that can be line-item-veto'ed :) >
commit 93f7973 looks good, although I wonder how much performance gain could we have from it. commit ce08bb2 looks good for me. Commit 4f0221b is not a sufficient fix and I think the full fix is here: http://gitorious.org/fish-shell/grissioms-fish-shell/commit/27df727ca11dfeac74214609771eacfccd4d5c08 commit 8a46a8e seems big. Is there any use case? Commit 0cf2a1e seems good. Besides, all your commits use 4 space as indent(as seen from the gitorious web interface). Original fish source use tab as indent. Keep with it as much as possible please. ;) > -Dave > > On Fri, Nov 5, 2010 at 9:02 AM, David Frascone <[email protected]> wrote: >> >> I'll re-evaluate the larger one, and split it into smaller chunks, if I >> think the issues are still there. >> >> -Dave >> >> >> On Fri, Nov 5, 2010 at 8:54 AM, Grissiom <[email protected]> wrote: >>> >>> Hi David, >>> >>> On Fri, Nov 5, 2010 at 9:06 PM, David Frascone <[email protected]> wrote: >>> > >>> > I'm not sure of the "right" way to do it -- but I requested a merge on >>> > gitorious that will incorporate the changes I've made over the last >>> > year via >>> > github. >>> > >>> > Let me know if you need more comments / etc. >>> > >>> >>> Thanks! But the commit 8cc7202 is too big that at least I would not >>> like to merge. commit caa6e26 is OK for me. >>> >>> BTW, the null TERM bug has been fixed by my 6654fff37 commit(which >>> inspired by your commit on github actually ;) ). and the parameter >>> parser bug has been fixed by my 27df727c commit. >>> >>> -- >>> Cheers, >>> Grissiom >> > > -- Cheers, Grissiom ------------------------------------------------------------------------------ The Next 800 Companies to Lead America's Growth: New Video Whitepaper David G. Thomson, author of the best-selling book "Blueprint to a Billion" shares his insights and actions to help propel your business during the next growth cycle. Listen Now! http://p.sf.net/sfu/SAP-dev2dev _______________________________________________ Fish-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/fish-users
