Hi Dylan,
On 27 November 2010 11:24, Dylan Smith <dylan.ah.sm...@gmail.com> wrote:
> On Fri, Nov 26, 2010 at 6:02 AM, Grissiom <chaos.pro...@gmail.com> wrote:
> > BTW, do you have account in gitorious? If so, maybe someone can add
> > you as developer in gitorious.
>
> I just created a gitorious account under the username dylansmith. I
> created a clone of the fish-shell repository, so it should be listed
> under the repository clones on the site. None of this required being a
> developer.
>
> What is the purpose of being added as a developer? I am used to just
> sending patches to a mailing list, should I be sending merge requests
> as well as or instead of sending patches to the fish-users mailing
> list?
>
The main reason behind being added to that group is to gain write access to
the main repo.
Having a cloned repo on gitorious as well is a separate thing -- and not
strictly needed (it's just another git repo, after all).
But it does have the nice thing of that merge request button, when you have
changes you want sent "upstream".
It's not too different to a normal emailed patch, except comments/questions
can be added to the patch as a whole, or to specific lines... etc. Just a
prettier way of gathering any code review type conversations, I suppose.
It's all pretty informal, but the pattern we've fallen into so far is just
pushing changes to our personal clones, and when we're happy with them,
firing off a merge request, and having another guy apply that request to the
target branch. Just as a way of making sure someone else actually looks at
the change, and that it applies cleanly to someone else's copy of the
repo...
>
> By the way, should I be basing my changes on fish-next or master? I
> am primarily a Wine developer where all our development is against the
> master branch, and occasionally they cherry-pick unintrusive patches
> to the stable branch (e.g. translations).
>
Again, nothing has been set in stone. For a long time the gitorious repo
has been acting as a mirror of the code in the original darcs repo, so the
master branch kind of naturally became the de facto 'stable' branch. So far
we've been trying only to put bug fixes there.
fish-next is were we're thinking of aiming any newer things that come along,
to be merged into master when they've been tried out a bit.
Better ideas welcome! :)
------------------------------------------------------------------------------
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
_______________________________________________
Fish-users mailing list
Fish-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/fish-users
