Hey Maxim, I've pushed a new version with your changes + suggestions integrated.
A few notes: - I changed 'functions -e vi_mode_user' to 'functions -q' - I assume that is what you meant. - Some indentation whitespace changes - I've added a vi modeline to try to ensure consistency in the future. - I've changed how the __vi_mode_* variables work to avoid breaking directional commands. - All functions are now prefixed with __vi_mode_, with the following exceptions: vi_mode_normal (as we expect it to be called from fish_user_keybindings) vi_mode and vi_mode_* variables (as we expect the user to get/set them from fish_prompt) The idea here being to distinguish between functions/variables that we expect a user to access (prefixed with vi_mode_) vs. internal only functions (prefixed with __vi_mode_). What is your take on this matter? I'd certainly appreciate any further feedback you have :) Cheers, -Ian -- http://sites.google.com/site/DarkStarJunkSpace -- http://darkstarshout.blogspot.com/ -- On the day *I* go to work for Microsoft, faint oinking sounds will be heard from far overhead, the moon will not merely turn blue but develop polkadots, and hell will freeze over so solid the brimstone will go superconductive. -- Eric S. Raymond, 2005 -- Please avoid sending me Word or PowerPoint attachments. See http://www.gnu.org/philosophy/no-word-attachments.html ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Fish-users mailing list Fish-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/fish-users
