The python uk list have gone with the 'cool kids' and set the default
return to be the list, but some people hate that.

My diff is definitely a quick hack, thanks for making a better one

Steve


On Wed, May 22, 2013 at 9:48 PM, David Frascone <d...@frascone.com> wrote:

> Oops -- forgot to cc list.
>
>
> On Wed, May 22, 2013 at 2:40 PM, David Frascone <d...@frascone.com> wrote:
>
>> I used a bit more #ifdef logic . . . .
>>
>> Patch attached.
>>
>>
>> On Wed, May 22, 2013 at 1:35 PM, Stestagg <stest...@gmail.com> wrote:
>>
>>> Reposting to the list:
>>>
>>> Hi
>>>
>>> I've just downloaded cygwin and given it a go.
>>>
>>> I've got it to work (largely) by applying the following patch:
>>>
>>> diff --git a/builtin_set_color.cpp b/builtin_set_color.cpp
>>> index 14cf84c..a45bde7 100644
>>> --- a/builtin_set_color.cpp
>>> +++ b/builtin_set_color.cpp
>>> @@ -12,7 +12,7 @@ Functions used for implementing the set_color builtin.
>>>  #if HAVE_NCURSES_H
>>>  #include <ncurses.h>
>>>  #else
>>> -#include <curses.h>
>>> +#include <ncurses/ncurses.h>
>>>  #endif
>>>
>>>  #if HAVE_TERM_H
>>> diff --git a/expand.cpp b/expand.cpp
>>> index 74e5010..d45ab9c 100644
>>> --- a/expand.cpp
>>> +++ b/expand.cpp
>>> @@ -18,7 +18,7 @@ parameter expansion.
>>>  #include <limits.h>
>>>  #include <sys/param.h>
>>>  #include <sys/types.h>
>>>  -#include <sys/sysctl.h>
>>> +//#include <sys/sysctl.h>
>>>  #include <termios.h>
>>>  #include <dirent.h>
>>>  #include <sys/stat.h>
>>> diff --git a/fallback.h b/fallback.h
>>> index eba91be..9dd4709 100644
>>> --- a/fallback.h
>>> +++ b/fallback.h
>>> @@ -93,8 +93,8 @@ int tputs(const char *str, int affcnt, int
>>> (*fish_putc)(tputs_arg_t));
>>>     work around this here.
>>>  */
>>>
>>> -#define tparm tparm_solaris_kludge
>>> -char *tparm_solaris_kludge(char *str, ...);
>>> +//#define tparm tparm_solaris_kludge
>>> +//char *tparm_solaris_kludge(char *str, ...);
>>>
>>>  #endif
>>>
>>>
>>> when fish starts up there are a few error messages, but things seem to
>>> be mainly working.
>>>
>>> Thanks
>>>
>>> Steve
>>>
>>>
>>> On Wed, May 22, 2013 at 7:15 PM, Costin Caraivan <
>>> costincarai...@gmail.com> wrote:
>>>
>>>> Hello there!
>>>>
>>>> I am one of those poor souls that are stuck in Windows. The reasons
>>>> for this are not very important, but I'm here and I have to make do
>>>> with whatever tools I have.
>>>>
>>>> Fish seems awesome but I saw no mention of a Windows (Cygwin port). I
>>>> didn't know the difficulty of this task, so I set about to pass the
>>>> first hurdle - compile Fish in Cygwin.
>>>>
>>>> So I went to this page:
>>>> https://github.com/fish-shell/fish-shell/#building  and I started
>>>> installing the required dependencies.
>>>> This is the final list of package installed:
>>>> http://paste.ubuntu.com/5684738/ - I hope I have everything needed to
>>>> build Fish.
>>>>
>>>> Anyway, I started the process:
>>>>
>>>> autoconf - OK
>>>> ./configure - OK
>>>> make - NOT OK
>>>> make install - Didn't even reach this
>>>>
>>>> First error I got during make:
>>>> g++ -g -O2 -D_LARGEFILE_SOURCE=1 -D_FILE_OFFSET_BITS=64
>>>> -fno-exceptions -Wall -DLOCALEDIR=\"/usr/local/share/locale\"
>>>> -DPREFIX=L\"/usr/local\" -DDATADIR=L\"/usr/local/share\"
>>>> -DSYSCONFDIR=L\"/usr/local/etc\" -DBINDIR=L\"/usr/local/bin\"    -c -o
>>>> builtin.o builtin.cpp
>>>> In file included from builtin.cpp:397:0:
>>>> builtin_set_color.cpp:15:20: fatal error: curses.h: No such file or
>>>> directory
>>>> compilation terminated.
>>>> <builtin>: recipe for target `builtin.o' failed
>>>> make: *** [builtin.o] Error 1
>>>>
>>>> Ok, it couldn't find curses.h.
>>>> Apparently it's not in the include path, so I hacked that:
>>>>
>>>> ln -s /usr/include/ncurses/curses.h /usr/include/
>>>>
>>>> and I got this:
>>>> g++ -g -O2 -D_LARGEFILE_SOURCE=1 -D_FILE_OFFSET_BITS=64
>>>> -fno-exceptions -Wall -DLOCALEDIR=\"/usr/local/share/locale\"
>>>> -DPREFIX=L\"/usr/local\" -DDATADIR=L\"/usr/local/share\"
>>>> -DSYSCONFDIR=L\"/usr/local/etc\" -DBINDIR=L\"/usr/local/bin\"    -c -o
>>>> builtin.o builtin.cpp
>>>> In file included from builtin_set_color.cpp:15:0,
>>>>                  from builtin.cpp:397:
>>>> fallback.h:97:7: error: previous declaration of ‘char*
>>>> tparm_solaris_kludge(char*, ...)’ with ‘C++’ linkage
>>>> /usr/include/curses.h:820:63: error: conflicts with new declaration
>>>> with ‘C’ linkage
>>>> <builtin>: recipe for target `builtin.o' failed
>>>> make: *** [builtin.o] Error 1
>>>>
>>>> Looks bad - and I'm stuck here.
>>>>
>>>> Here's the gcc -v output - hope it helps:
>>>> http://paste.ubuntu.com/5684749/
>>>>
>>>>
>>>> I'm willing to try out various builds and provide any debugging
>>>> information needed if there's a chance of making Fish run under
>>>> Cygwin.
>>>>
>>>> Thank you for your attention! :)
>>>>
>>>> _____________
>>>> Costin Caraivan
>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> Try New Relic Now & We'll Send You this Cool Shirt
>>>> New Relic is the only SaaS-based application performance monitoring
>>>> service
>>>> that delivers powerful full stack analytics. Optimize and monitor your
>>>> browser, app, & servers with just a few lines of code. Try New Relic
>>>> and get this awesome Nerd Life shirt!
>>>> http://p.sf.net/sfu/newrelic_d2d_may
>>>> _______________________________________________
>>>> Fish-users mailing list
>>>> Fish-users@lists.sourceforge.net
>>>> https://lists.sourceforge.net/lists/listinfo/fish-users
>>>>
>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Try New Relic Now & We'll Send You this Cool Shirt
>>> New Relic is the only SaaS-based application performance monitoring
>>> service
>>> that delivers powerful full stack analytics. Optimize and monitor your
>>> browser, app, & servers with just a few lines of code. Try New Relic
>>> and get this awesome Nerd Life shirt!
>>> http://p.sf.net/sfu/newrelic_d2d_may
>>> _______________________________________________
>>> Fish-users mailing list
>>> Fish-users@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/fish-users
>>>
>>>
>>
>
------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
_______________________________________________
Fish-users mailing list
Fish-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/fish-users

Reply via email to