On Fri, Nov 15, 2002 at 09:07:39PM +0100, Miroslav Lichvar wrote:
> Here is preliminary patch for fileinfo for xmms plugin. Saving and
> removing of the tag isn't working.

Ok, no comments, so here it is.

> When saving, how handle id3v1, v2?
It manipulate (display, edit, remove) only vorbis comment, nothing
else. When saving or removing, only displayed values will be changed. This
keeps other fields in block untouched.

If there are more fields with same name in comment block, only last
one will be manipulated. If the field is removed, next field with
such name will "appear".

> Display and edit more fields (e.g. performer)?
No.

> How handle genres? Combo with predefined values?
Cut and pasted from vorbis plugin.

BTW, when new vorbis comment block is shorter than old block, it would
be cool if FLAC__metadata_simple_iterator_set_block extended contiguous
padding block (instead of making new padding block).

-- 
Miroslav Lichvar

Attachment: xmms_plugin_fileinfo.patch.gz
Description: Binary data

Reply via email to