Hello,
The attached patch fixes a typo in md5.c, where a memset is used to
clear the digest, but only ends up clearing parts of it due to a
missing dereference operator.
Would it be possible to get this applied? It is not fixing a serious
bug, but this warning comes up in the Chromium build, and fixing it
would make the build one bit less noisy.
Thanks,
Hans
Index: src/libFLAC/md5.c
===================================================================
RCS file: /cvsroot/flac/flac/src/libFLAC/md5.c,v
retrieving revision 1.18
diff -u -u -r1.18 md5.c
--- src/libFLAC/md5.c 3 Jan 2009 02:10:18 -0000 1.18
+++ src/libFLAC/md5.c 30 Jan 2012 14:02:09 -0000
@@ -259,7 +259,7 @@
byteSwap(ctx->buf, 4);
memcpy(digest, ctx->buf, 16);
- memset(ctx, 0, sizeof(ctx)); /* In case it's sensitive */
+ memset(ctx, 0, sizeof(*ctx)); /* In case it's sensitive */
if(0 != ctx->internal_buf) {
free(ctx->internal_buf);
ctx->internal_buf = 0;
_______________________________________________
flac-dev mailing list
[email protected]
http://lists.xiph.org/mailman/listinfo/flac-dev
