Small remark:

> diff --git a/src/libFLAC/Makefile.am b/src/libFLAC/Makefile.am
> index 13ab593..aa88100 100644
> --- a/src/libFLAC/Makefile.am
> +++ b/src/libFLAC/Makefile.am
> @@ -34,6 +34,9 @@ noinst_LTLIBRARIES = libFLAC-static.la
> if DEBUG
> DEBUGCFLAGS = -DFLAC__OVERFLOW_DETECT
> endif
> +
> +# FIXME: The following logic should be part of configure, not of Makefile.am
> +
> if FLaC__CPU_PPC
> # The -force_cpusubtype_ALL is needed to insert a ppc64 instruction
> # into cpu.c with an asm().

I committed this FIXME comment by mistake, although I stand by its content ;). 
Anyway, it logically does not really belong into this commit, so you may want 
to prune it before applying. Alternatively, I can also re-roll the patch series 
(and if I have to re-roll it anyway for other reasons, I'll remove it, too).


Cheers,
Max

_______________________________________________
flac-dev mailing list
[email protected]
http://lists.xiph.org/mailman/listinfo/flac-dev

Reply via email to