Hi,
Running make fullcheck was broken here, and I found out it has
been that way since commit 1d3d50 which changed from the sheel
from /bin/sh to /bin/bash -e. There are a few cuesheet tests
that are designed to fail, which made /bin/bash -e trigger a
non-zero exit status.
Attached is a patch to fix this.
>From c78f9d13087fbaf435cea3b380a929466c5860c7 Mon Sep 17 00:00:00 2001
From: Martijn van Beurden <mva...@gmail.com>
Date: Mon, 3 Mar 2014 14:17:56 +0100
Subject: [PATCH] Repairs test_grabbag.sh
The change from /bin/sh to /bin/bash -e (commit 1d3d50) broke
the cuesheet tests. This should fix it
---
test/test_grabbag.sh | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/test/test_grabbag.sh b/test/test_grabbag.sh
index 923c812..dfa4a84 100755
--- a/test/test_grabbag.sh
+++ b/test/test_grabbag.sh
@@ -97,8 +97,7 @@ rm -f $log
#
for cuesheet in $bad_cuesheets ; do
echo "NEGATIVE $cuesheet" >> $log 2>&1
- run_test_cuesheet $cuesheet $good_leadout 44100 cdda >> $log 2>&1
- exit_code=$?
+ run_test_cuesheet $cuesheet $good_leadout 44100 cdda >> $log 2>&1 || exit_code=$?
if [ "$exit_code" = 255 ] ; then
die "Error: test script is broken"
fi
--
1.8.3.2
_______________________________________________
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
