Hi Erik, Thanks for looking over my patch.
> > * Account for the updates to UTF-8 on Windows. > > One of these updates, added an "#ifdef _WIN32" to the file > src/share/win_utf8_io/win_utf8_io.c. Is this really necessary? Is > it not possible to just not include that file when not compiling > for windows? You're right. I changed my patch to only specify "-lwin_utf8_io" under Windows. > Those Makefile variables are somewhat non-standard. Is there any > reason you chose CCFLACGS and CCCFLAGS instead of the more usual > CFLAGS and CXXFLAGS? I usually see the C++ compiler as CXX, while FLAC uses CCC. I suppose that threw me off. Updated my patch to use CFLAGS and CXXFLAGS. > I would appreciate it if you could update you patch to address > the issues I raised above. I attached a revised patch. -H
flac-update-Makefile-lite-20140623.patch.gz
Description: GNU Zip compressed data
_______________________________________________ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
