On 01/18/16 07:42 AM, lvqcl wrote:
Dave Yeo wrote:
>Seems that the default binutils on OS/2 is too old to support AVX2,
>attached patch works around this. Not the best solution as best would be
>configure tests, but simple.
Are you sure that these binutils support AVX and FMA? (Currently libFLAC
doesn't contain AVX and FMA instructions). If they aren't supported then
it's better to include them too into #if !defined __OS2__ ... #endif.
The nature of the error implies AVX2 support that is missing but I'm not
much up on assembly,
make[4]: Entering directory `K:/usr/local/src/flac/src/libFLAC'
CC lpc_intrin_avx2.lo
R:/tmp/ccwvrScM.s: Assembler messages:
R:/tmp/ccwvrScM.s:495: Error: operand type mismatch for `vbroadcastss'
...
R:/tmp/ccwvrScM.s:8773: Error: operand type mismatch for `vpsrlq'
R:/tmp/ccwvrScM.s:8778: Error: no such instruction: `vpermd
%ymm1,%ymm5,%ymm0'
R:/tmp/ccwvrScM.s:8859: Error: operand type mismatch for `vpmovzxdq'
...
Best to be safe so updated patch attached.
I've also opened a ticket, http://trac.netlabs.org/rpm/ticket/165#ticket
Dave
From dc164a696709fc9965a1c8c452800c596872d993 Mon Sep 17 00:00:00 2001
From: Dave Yeo <dave.r.yeo@gmail.com>
Date: Mon, 18 Jan 2016 10:31:51 -0800
Subject: [PATCH] OS/2 currently has too old of a binutils to support AVX
Signed-off-by: Dave Yeo <dave.r.yeo@gmail.com>
---
src/libFLAC/include/private/cpu.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/libFLAC/include/private/cpu.h b/src/libFLAC/include/private/cpu.h
index 380f4f0..1c8428c 100644
--- a/src/libFLAC/include/private/cpu.h
+++ b/src/libFLAC/include/private/cpu.h
@@ -78,9 +78,11 @@
#define FLAC__SSE2_SUPPORTED 1
#define FLAC__SSSE3_SUPPORTED 1
#define FLAC__SSE4_1_SUPPORTED 1
+#if !defined __OS2__
#define FLAC__AVX_SUPPORTED 1
#define FLAC__AVX2_SUPPORTED 1
#define FLAC__FMA_SUPPORTED 1
+#endif
#else /* for GCC older than 4.9 */
#define FLAC__SSE_TARGET(x)
#ifdef __SSE__
--
2.0.0
_______________________________________________
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
