Hi Steve,
1. Use static methods/properties instead of singleton. Gets rid of '.getInstance().' cruft.
Well. In this case I prefer it used as a singleton - don't know why really, but it just seems more correct to me.
2. Remove the setVar() method since these properties really should be read only. Move this into your settings class if you need it.
But it's private anyways. Is made to be used by subclasses.
3. Use composition in the SomeSettingsClass class rather than inheritance since this isn't an 'is a' relationship.
That would require more code, and the ability to overturn dynamicness through inheritance makes this seem preferable to me.
And I actually find the relationship as being an "is a" - as the settingsclass would be used only for FlashVars-variables. Other settings (read from XML and more) could of course be read in as well, in which case composition would be preferable.
But I do follow your concerns on all three matters.
It's also worth noting that the Flex 2 framework has a nice method of abstracting FlashVars via the Application.application.parameters array.
Those will be the days... :) -- Morten Barklund _______________________________________________ [email protected] To change your subscription options or search the archive: http://chattyfig.figleaf.com/mailman/listinfo/flashcoders Brought to you by Fig Leaf Software Premier Authorized Adobe Consulting and Training http://www.figleaf.com http://training.figleaf.com
