I think directly calling an event handler (meaning, you also have code call it, it doesn't just fire automatically from an event) and passing it a null argument is bad architecture. I think the preferred way would be to create a separate function to handle logic as per my examples, and keep event handlers as event handlers. Otherwise, you're making an event handler also a "normal" function. You certainly can have, and often should have, logic within the event handler, but if you also want that logic to be run from a non-event (like calling it with code), then you should have a separate function for that logic.
Jason Merrill Instructional Technology Architect Bank of America Global Learning _______________________ -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Wenzler, Thomas Sent: Monday, December 20, 2010 4:27 AM To: [email protected] Subject: [Flashcoders] Re: error msg Jason, Is that considered bad practice in lieu of code readability or is there another pitfall I just don't see? I'm only asking because in my short past of writing AS3 I called Event Handlers with an argument of 'null' sometimes to save on function single-liners like doIt(); Best Thomas ------------------------------ Message: 9 Date: Thu, 16 Dec 2010 19:48:16 -0500 From: "Merrill, Jason" <[email protected]> Subject: RE: [Flashcoders] error mesg To: Flash Coders List <[email protected]> Message-ID: <[email protected]> Content-Type: text/plain; CHARSET=US-ASCII You shouldn't be manually calling an event handler in your code. If you want multiple event handler functions to run the same set of code, then create a third function that they all call. function onSomething(event:Event):void { doIt(); } function onSomethingElse(event:Event) { doIt(); } function doIt():void { //doStuff. } Jason Merrill Instructional Technology Architect Bank of America Global Learning _______________________________________________ Flashcoders mailing list [email protected] http://chattyfig.figleaf.com/mailman/listinfo/flashcoders ---------------------------------------------------------------------- This message w/attachments (message) is intended solely for the use of the intended recipient(s) and may contain information that is privileged, confidential or proprietary. If you are not an intended recipient, please notify the sender, and then please delete and destroy all copies and attachments, and be advised that any review or dissemination of, or the taking of any action in reliance on, the information contained in or attached to this message is prohibited. Unless specifically indicated, this message is not an offer to sell or a solicitation of any investment products or other financial product or service, an official confirmation of any transaction, or an official statement of Sender. Subject to applicable law, Sender may intercept, monitor, review and retain e-communications (EC) traveling through its networks/systems and may produce any such EC to regulators, law enforcement, in litigation and as required by law. The laws of the country of each sender/recipient may impact the handling of EC, and EC may be archived, supervised and produced in countries other than the country in which you are located. This message cannot be guaranteed to be secure or free of errors or viruses. References to "Sender" are references to any subsidiary of Bank of America Corporation. Securities and Insurance Products: * Are Not FDIC Insured * Are Not Bank Guaranteed * May Lose Value * Are Not a Bank Deposit * Are Not a Condition to Any Banking Service or Activity * Are Not Insured by Any Federal Government Agency. Attachments that are part of this EC may have additional important disclosures and disclaimers, which you should read. This message is subject to terms available at the following link: http://www.bankofamerica.com/emaildisclaimer. By messaging with Sender you consent to the foregoing. _______________________________________________ Flashcoders mailing list [email protected] http://chattyfig.figleaf.com/mailman/listinfo/flashcoders
