Since we don't have any debug level printing infrastructure yet, I propose to kill the obnoxious debug message in ichspi.c which was added to check for correct PREOP handling. We know the code works fine (after getting a few reports over 100 MB long) and there's no point in keeping it around anymore. If there is any desire, we can reinstate it as print_spew or whatever once the debug level infrastructure is merged, but at that point we probably just are happy that the debug output isn't there anymore.
Signed-off-by: Carl-Daniel Hailfinger <[email protected]> Index: flashrom-ich_preop_silence/ichspi.c =================================================================== --- flashrom-ich_preop_silence/ichspi.c (Revision 752) +++ flashrom-ich_preop_silence/ichspi.c (Arbeitskopie) @@ -756,11 +756,8 @@ * opcode of the next command? */ if ((oppos != -1) && (preoppos != -1) && - (curopcodes->opcode[oppos].atomic - 1 == preoppos)) { - printf_debug("opcode 0x%02x will be run as PREOP\n", - cmds->writearr[0]); + (curopcodes->opcode[oppos].atomic - 1 == preoppos)) continue; - } } ret = ich_spi_send_command(cmds->writecnt, cmds->readcnt, -- Developer quote of the week: "We are juggling too many chainsaws and flaming arrows and tigers." _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
