On 2009-12-02 16:51, Carl-Daniel Hailfinger wrote:
Hi Adam,
thanks for your patch.
On 02.12.2009 16:34, Adam Jurkowski wrote:
Add support for Intel Poulsbo chipset.
Signed-off-by: Adam Jurkowski <[email protected]>
Is there any reason you can't call enable_flash_ich(dev, name, 0xd8)?
That would eliminate some of the code.
Now enable_flash_ich is re-used.
I've also removed IDSEL and BDE register changing part. It was useful
only for the case when default register values was modified.
Best regards,
Adam
Index: jedec.c
===================================================================
--- chipset_enable.c (revision 791)
+++ chipset_enable.c (working copy)
@@ -4,6 +4,7 @@
* Copyright (C) 2000 Silicon Integrated System Corporation
* Copyright (C) 2005-2009 coresystems GmbH
* Copyright (C) 2006 Uwe Hermann <[email protected]>
+ * Copyright (C) 2009 Kontron Modular Computers GmbH
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@@ -399,6 +400,26 @@
return enable_flash_ich(dev, name, 0xdc);
}
+static int enable_flash_poulsbo(struct pci_dev *dev, const char *name)
+{
+ uint16_t old, new;
+ int err;
+
+ if ((err = enable_flash_ich(dev, name, 0xd8)) != 0)
+ return err;
+
+ old = pci_read_byte(dev, 0xd9);
+ printf_debug("BIOS Prefetch Enable: %sabled, ",
+ (old & 1) ? "en" : "dis");
+ new = old & ~1;
+
+ if (new != old)
+ pci_write_byte(dev, 0xd9, new);
+
+ return 0;
+}
+
+
#define ICH_STRAP_RSVD 0x00
#define ICH_STRAP_SPI 0x01
#define ICH_STRAP_PCI 0x02
@@ -1139,6 +1160,7 @@
{0x8086, 0x7000, OK, "Intel", "PIIX3", enable_flash_piix4},
{0x8086, 0x7110, OK, "Intel", "PIIX4/4E/4M", enable_flash_piix4},
{0x8086, 0x122e, OK, "Intel", "PIIX", enable_flash_piix4},
+ {0x8086, 0x8119, OK, "Intel", "Poulsbo", enable_flash_poulsbo},
{0x10de, 0x0030, OK, "NVIDIA", "nForce4/MCP4", enable_flash_nvidia_nforce2},
{0x10de, 0x0050, OK, "NVIDIA", "CK804", enable_flash_ck804}, /* LPC */
{0x10de, 0x0051, OK, "NVIDIA", "CK804", enable_flash_ck804}, /* Pro */
_______________________________________________
flashrom mailing list
[email protected]
http://www.flashrom.org/mailman/listinfo/flashrom
