On 16.12.2009 03:59, Sean Nelson wrote:
> As Carl-Daniel's says:
> probe_jedec checks the delay value and issues programmer_delay based
> on the value. Except for delays between single chip_writeb. If a chip
> has zero probe_delay, delays between chip_writeb should be skipped.
>
> Signed-off-by: Sean Nelson <[email protected]>

Thanks! With one minor stylistic change, this is committable.

> --- jedec.c   (revision 803)
> +++ jedec.c   (working copy)
> @@ -96,11 +96,11 @@
>  
>       /* Issue JEDEC Product ID Entry command */
>       chip_writeb(0xAA, bios + 0x5555);
> -     programmer_delay(10);
> +     if (probe_timing_enter) programmer_delay(10);
>   

Should be
> -     programmer_delay(10);
> +     if (probe_timing_enter)
>               programmer_delay(10);
>   

 Acked-by: Carl-Daniel Hailfinger <[email protected]>

Please resend, and already include my ack in your changelog. I will then
commit immediately.

Regards,
Carl-Daniel

-- 
Developer quote of the month: 
"We are juggling too many chainsaws and flaming arrows and tigers."


_______________________________________________
flashrom mailing list
[email protected]
http://www.flashrom.org/mailman/listinfo/flashrom

Reply via email to