On 20.12.2009 00:59, Carl-Daniel Hailfinger wrote:
> On 19.12.2009 20:41, Idwer Vollering wrote:
>   
>> Include detailed versioning information in the binary (--version).
>>
>> Signed-off-by: Idwer Vollering <[email protected]>
>>   
>>     
>
> Thanks for your patch. While I like the general idea, this specific
> implementation makes porting to Windows more difficult. Can you move all
> the utsname printing stuff to a separate function in internal.c which is
> called from print_version?
>   

A good name for the new function would be print_sysinfo().

Regards,
Carl-Daniel

-- 
Developer quote of the month: 
"We are juggling too many chainsaws and flaming arrows and tigers."


_______________________________________________
flashrom mailing list
[email protected]
http://www.flashrom.org/mailman/listinfo/flashrom

Reply via email to