On 22.12.2009 21:46, Sean Nelson wrote: > Convert the following chips to use struct eraseblock: > AT25DF021 > AT25DF041A > AT25DF081 > AT25DF161 > AT25DF321 > AT25DF321A > AT25DF641 > AT25F512B > AT25FS010 > AT25FS040 > AT26DF041 > AT26DF081A > AT26DF161 > AT26DF161A > AT26F004 > AT29C512 > AT29C010A > AT29C020 > AT29C040A > AT49BV512 > AT49F002(N) > AT49F002(N)T > > Signed-off-by: Sean Nelson <[email protected]>
Sorry if my reviews seem to be obnoxious, but I noticed an oddness you surely can explain: Chips with the old erase function spi_chip_erase_60_c7 seem to be missing the c7 variant after conversion. And I think some of the chips supports both 52 and d8 for block erase with same sector size and only one is listed. We have to list all known erase function variants even if they have identical eraseblock sizes because on Intel/VIA chipsets one (or more) of the commands may be forbidden by the chipset configuration. I'm impressed by the amount of datasheet reading you did in such short time. Keep up the good work! Regards, Carl-Daniel -- Developer quote of the month: "We are juggling too many chainsaws and flaming arrows and tigers." _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
