On 16.03.2010 23:40, Rudolf Marek wrote: > > I added a short version of your description to the flashrom README. > > Ok > > > > I made some more changes to the Makefile. "make dos" is something I'd > > rather avoid because it hardcodes too many assumptions. > > I would prefer to have there something like: > > make djgpp-dos > > because I will tend to forgot how to invoke the make from command line. > > > >> Index: physmap.c > >> =================================================================== > >> --- physmap.c (revision 935) > >> +++ physmap.c (working copy) > >> @@ -4,6 +4,7 @@ > >> * Copyright (C) 2009 Peter Stuge <[email protected]> > >> * Copyright (C) 2009 coresystems GmbH > >> * Copyright (C) 2010 Carl-Daniel Hailfinger > >> + * Copyright (C) 2010 Rudolf Marek <[email protected]> > >> * > >> * This program is free software; you can redistribute it and/or > modify > >> * it under the terms of the GNU General Public License as > published by > >> @@ -27,7 +28,77 @@ > >> #include <errno.h> > >> #include "flash.h" > >> > >> -#ifdef __DARWIN__ > >> +#ifdef __DJGPP__ > >> [...] > >> +#elif __DARWIN__ > >> > > Can you change this to > > #elif defined(__DARWIN) > > to keep the logic as it was? I don't have a Mac OS X machine, so I can't > > test... > > yes sorry fixed. > > > >> + > >> #include <DirectIO/darwinio.h> > >> > >> #define MEM_DEV "DirectIO" > >> > > If you drop the board_enable.c hunk (and if my latest Makefile+README > > patch is OK for you), this is > > Acked-by: Carl-Daniel Hailfinger <[email protected]> > > > I can update the README once your pciutils patch has been merged. > > > I dont know who can commit this, I'm attaching the fixed patch. > > Signed-off-by: Rudolf Marek <[email protected]> > > Please check that in, so at least something is there ;) > The libpci fixes etc can wait until Martin shows up.
Except for the Makefile (which needs more discussion) this is Acked-by: Carl-Daniel Hailfinger <[email protected]> Thanks a lot for making this possible. Regards, Carl-Daniel -- "I do consider assignment statements and pointer variables to be among computer science's most valuable treasures." -- Donald E. Knuth _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
