On 14.03.2010 16:42, Michael Karcher wrote: > No merge of boards_need_enable and the board enable table as I would never > get that patch past Luc Verhaegen. But a consistency check for these two > tables can be added to the flashrom selftest. > > Note, this DEMO patch is broken in that it does not print "-m" parameters > anymore. > > Signed-off-by: Michael Karcher <[email protected]>
Hm. I'm not exactly thrilled about this patch (not your fault). Yes, it reduces a sizable amount of duplication. Yes, it reduces the amount of consistency checking we have to do. Yes, it will probably reduce the number of mismatch bugs each time someone adds a new board. Still, the original reason I didn't want URLs and board names in the same master table is that I personally think URLs are ugly and should not be in flashrom at all. print_wiki.c allowed me to ignore that stuff without having to sacrifice working on any board lists. I can just pretend print_wiki doesn't exist and be happy. ;-) I won't veto the patch for two reasons: 1. You create most board enables and add most supported boards nowadays, so this is much more "your" turf than mine, and it should be in a state that makes development easier for you. 2. Uwe created most of the printing (and IIRC all of the wiki) code, so he will know if this patch is a good idea or not. If Uwe acks this, go ahead. Regards, Carl-Daniel -- http://www.hailfinger.org/ _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
