On 02.04.2010 23:57, David Hendricks wrote: > On Wed, Mar 24, 2010 at 7:10 PM, Carl-Daniel Hailfinger < > [email protected]> wrote: > > >> Every SPI programmer driver had its own completely different chip write >> implementation, and all of them were insufficiently commented. >> Create spi_write_chunked as a copy of spi_read_chunked and convert all >> SPI programmers to use it. >> No functional changes except: >> - Bus Pirate uses 12 Byte writes instead of 8 Byte writes >> - SB600 uses 5 Byte writes instead of 1 Byte writes >> > Looks like a step in the right direction to me, I'd love to see it post > 0.9.2. I even had a chance to test it on Intel and VIA SPI controllers, and > it seemed not to break anything :-) > > Acked-by: David Hendricks <[email protected]> >
Nice, thanks for the review. Regards, Carl-Daniel -- http://www.hailfinger.org/ _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
