Hi Jörg, thank you for the patch.
On 19.05.2010 01:51, Jörg Fischer wrote: > Jörg Fischer schrieb: > > >> here is the patch for RTL1839 based NICs. >> > > And here is the second version, which works. It should be applied to > a clean svn, without my first patch. > > >> Still got some problems: >> * Those Nics can have a wide varity of PCI (Vendor) IDs. >> > > .. which are not yet in the code. > We can add those later as they show up. >> * Code is instable, "erase" fails but "read" reads only FFs. >> > > Fixed. Must set nCS to "1" after reading a byte... > > >> It is disabled by default in the Makefile. >> Should we still disable it by default? You said it works now, and all working drivers should be enabled by default IMHO. > And another point: I read somewhere that RTL8139D and later Chips may > not have Flash Writing capability anymore. Read: no newer Cards :-( > That's unfortunate, but now we can support at least those chips which can write. I noticed the double init functions caused by a suboptimal interface of pcidev_init. I will change that later, but for now your patch will get merged as is. > Signed-off-by: Joerg Fischer <[email protected]> > Acked-by: Carl-Daniel Hailfinger <[email protected]> Is it intentional that the copyright says "TURBO J"? I think your drkaiser driver has your name in the copyright line. I'll commit shortly after 0.9.2 is out (which will happen tomorrow if I can get some Acks for that release.) Regards, Carl-Daniel -- http://www.hailfinger.org/ _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
