On 19.06.2010 03:05, David Borg wrote: > Updated the patch to include the comment that FEATURE_ADDR_2AA may be > needed for some chip revisions and > changed FEATURE_SHORT_RESET to FEATURE_EITHER_RESET. >
Excellent, thanks. > One question about FEATURE_EITHER_RESET, should it be used instead of > FEATURE_SHORT_RESET when the device supports both methods, even though > it defaults to the long reset method? > Good question. We may change the default reset method in the future to the short variant. Right now FEATURE_EITHER_RESET is about collecting as much reset information about the chip as possible. > Patch also includes support for the HY29F002B chip, as it is basically > the same chip, with only the sector ordering being different. > > HY29F002T code tested with an HY29F002TC-90 chip, on a GA-6VX7-4X > motherboard, and all features are working. (Logs attached) > I have no means of testing HY29F002B chips. > Thanks a lot for adding both chips. > Signed-off-by: David Borg <[email protected]> > There were some minor whitespace issues, but I'll fix them up when I commit in the morning. Acked-by: Carl-Daniel Hailfinger <[email protected]> Regards, Carl-Daniel -- http://www.hailfinger.org/ _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
