On 17.07.2010 15:53, Uwe Hermann wrote: > On Mon, Jul 12, 2010 at 07:05:43PM +0200, Carl-Daniel Hailfinger wrote: > >> Newer llvm/clang versions (since r102686) have a __clang_version__ macro >> which can be used to print the exact clang version. >> >> Fix a case where chip_to_probe was referenced twice via extern, once at >> the function level and once in a global include file. Found by latest clang. >> >> Tested on old and new clang. >> >> Signed-off-by: Carl-Daniel Hailfinger <[email protected]> >> > > Acked-by: Uwe Hermann <[email protected]> > > Looks good here, I tested with clang 2.6-3 from Debian unstable. > > Before: > flashrom v0.9.2-r1085 on Linux 2.6.32-5-amd64 (x86_64), built with libpci > 3.1.7, LLVM 1/clang 1, little endian > > After: > flashrom v0.9.2-r1085 on Linux 2.6.32-5-amd64 (x86_64), built with libpci > 3.1.7, LLVM Clang unknown version (before r102686), little endian >
Yes, clang support for version numbers started shortly after llvm 2.7. Before that, there was no version number available at all. Thanks, committed in r1087. Regards, Carl-Daniel -- http://www.hailfinger.org/ _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
