On Thu, Jul 29, 2010 at 07:11:36PM +0200, Carl-Daniel Hailfinger wrote:
> On 14.07.2010 06:44, Mattias Mattsson wrote:
> > This is a bit more intrusive than my earlier patch. It's a bit hard to
> > read in some places because keeping the definitions alphabetically
> > sorted.
> >
> > Add definitions for the following chips from
> >
> > Mosel Vitelic Corporation (MVC):
> >
> > V29C51000B
> > V29C51000T
> > V29C51400B
> > V29C51400T
> > V29LC51000
> > V29LC51001
> > V29LC51002
> >
> > SyncMOS (SM)/Mosel Vitelic Corporation (MVC)
> >
> > {F,S,V}29C51001B
> > {F,S,V}29C51001T
> > {F,S,V}29C51002B
> > {F,S,V}29C51002T
> > {F,S,V}29C51004B
> > {F,S,V}29C51004T
> > {V,S}29C31004B
> > {V,S}29C31004T
> >
> > Modifies earlier definitions of
> > S29C31004T/S29C51001T/S29C51002T/S29C51004T to change name and correct
> > page size. Also changes vendor and chip constants.
> >
> >
> > Signed-off-by: Mattias Mattsson <[email protected]>
> >   
> 
> I've changed the printed names, and removed the TEST_OK_WRITE for chips
> where page size changed.
> 
> Signed-off-by: Carl-Daniel Hailfinger <[email protected]>

Acked-by: Uwe Hermann <[email protected]>


Please use both Signed-off-by's in the commit.

 
> Index: flashrom-syncmos_moselvitelic_29c/flashchips.h
> ===================================================================
> --- flashrom-syncmos_moselvitelic_29c/flashchips.h    (Revision 1121)
> +++ flashrom-syncmos_moselvitelic_29c/flashchips.h    (Arbeitskopie)
> @@ -514,11 +514,22 @@
>  #define ST_M29W040B          0xE3
>  #define ST_M29W512B          0x27
>  
> -#define SYNCMOS_ID           0x40    /* SyncMOS and Mosel Vitelic */
> -#define S29C51001T           0x01
> -#define S29C51002T           0x02
> -#define S29C51004T           0x03
> -#define S29C31004T           0x63
> +#define SYNCMOS_MVC_ID               0x40    /* SyncMOS (SM) and Mosel 
> Vitelic Corporation (MVC) */

We should change this to MVI or something else in a follow-up commit.
I cannot find MVC used in any datasheet or the vendor website. On their
website they use the MVI abbreviation though (Mosel Vitelic Inc.).


Uwe.
-- 
http://hermann-uwe.de     | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org

_______________________________________________
flashrom mailing list
[email protected]
http://www.flashrom.org/mailman/listinfo/flashrom

Reply via email to