On Mon, Sep 13, 2010 at 20:29, Uwe Hermann <[email protected]> wrote:
>> +static int it8707f_write_enable(uint8_t port)
>> +{
>> +     uint8_t tmp;
>> +
>> +     w836xx_ext_enter(port);
>> +
>> +     tmp = sio_read(port, 0x23);
>> +     tmp |= 8;
>
> Please consider (1 << 3) for better readability.

Fixed. Also added some comments.

> Acked-by: Uwe Hermann <[email protected]>

Thanks, r1161


-mattias

_______________________________________________
flashrom mailing list
[email protected]
http://www.flashrom.org/mailman/listinfo/flashrom

Reply via email to