On 01.11.2010 23:01, David Hendricks wrote: > The patch seems very useful for testing and is benign at worst. I'd like to > see it in the tree since it greatly reduced the turnaround time for testing > partial writes and deserves some more usage. We can make it pretty later on > -- I'm already very happy to see a big mess of #defines gone from the > original patchset. > > fwiw: > Acked-by: David Hendricks <[email protected]> >
Thanks, committed in r1220. > On Sat, Oct 30, 2010 at 6:13 PM, Carl-Daniel Hailfinger wrote: > >> + case JEDEC_RDID: >> + if (emu_chip != EMULATE_SST_SST25VF032B) >> + break; >> + /* Respond with SST_SST25VF032B. */ >> + if (readcnt > 0) >> + readarr[0] = 0xbf; >> + if (readcnt > 1) >> + readarr[1] = 0x25; >> + if (readcnt > 2) >> + readarr[2] = 0x4a; >> + break; >> >> > > Minor nitpick: These should probably slice/dice the #defines from > flashchips.h. > I hoped to keep this dependency out of dummyflasher.c, but that hope probably won't last. Regards, Carl-Daniel -- http://www.hailfinger.org/ _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
