On Mon, Nov 1, 2010 at 8:04 PM, Carl-Daniel Hailfinger < [email protected]> wrote:
> On 02.11.2010 02:20, David Hendricks wrote: > > New version -- fixes the number of regions tested (i had reduced them to > get > > a patch prepped in a hurry. d'oh!) > > > > On Mon, Nov 1, 2010 at 6:10 PM, David Hendricks <[email protected]> > wrote: > > > > > >> We were a bit too aggressive in trimming superfluous print messages > earlier > >> on. This patch adds a line of output for each iteration of the while > loops > >> in the test. The intention is to give the user something useful to > indicate > >> test progress without just printing a ton of debug spew. Maybe a future > >> patch can redirect more verbose info to a log file. > >> > >> The output looks like this:: > >> localhost ~ # FLASHROM="./flashrom" sh flashrom_partial_write_test.sh > >> testing flashrom binary: ./flashrom > >> Running test in /tmp/tmp.4xPejwaADU > >> ffh pattern written in ff_4k.bin > >> 00h pattern written in 00_4k.bin > >> Reading BIOS image > >> Original image saved as bios.bin > >> aligned region 0 test: passed > >> ... > >> aligned region 15 test: passed > >> unaligned region 0 test: passed > >> ... > >> unaligned region 15 test: passed > >> Result: PASSED > >> restoring original bios image using system's flashrom > >> test files remain in /tmp/tmp.4xPejwaADU > >> > >> Signed-off-by: David Hendricks <[email protected]> > >> > > Looks good and improves the output. > I removed the /dev/null redirect of the final flashrom run since we > really want to know if the fail flashrom run had any issues. > Sounds good. Thanks! > > Acked-by: Carl-Daniel Hailfinger <[email protected]> > and committed in r1222. > > Regards, > Carl-Daniel > > -- > http://www.hailfinger.org/ > > -- David Hendricks (dhendrix) Systems Software Engineer, Google Inc.
_______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
