Am Dienstag, den 16.11.2010, 17:27 +0100 schrieb Carl-Daniel Hailfinger:
> Thanks to Michael Karcher for reviewing the patch and pointing out a
> missing abort on read failure.
> + ret = flash->read(flash, readbuf, start, len);
> + if (ret) {
> + msg_gerr("Verification impossible because read failed "
> + "at 0x%x (len 0x%x)\n", start, len);
> + return 1;
make this "return ret" to not lose the error code.
Otherwise, the patch looks good to me.
Acked-By: Michael Karcher <[email protected]>
Regards,
Michael Karcher
_______________________________________________
flashrom mailing list
[email protected]
http://www.flashrom.org/mailman/listinfo/flashrom
