Am 29.05.2011 01:50 schrieb Carl-Daniel Hailfinger: > Am 28.05.2011 05:38 schrieb Stefan Tauner: > >> @@ -709,8 +721,8 @@ static int ich9_run_opcode(OPCODE op, uint32_t offset, >> temp32 = REGREAD32(ICH9_REG_SSFS); >> /* Keep reserved bits only */ >> temp32 &= SSFS_RESERVED_MASK | SSFC_RESERVED_MASK; >> - /* clear error status registers */ >> - temp32 |= (SSFS_CDS + SSFS_FCERR); >> + /* Clear cycle done and cycle error status registers */ >> + temp32 |= (SSFS_FDONE + SSFS_FCERR); >> >> > Odd. Did we really have + instead of | here? That looks wrong (yes, > technically it is correct, but still, it suggests that the values are > numeric instead of individual bits). Now that you're touching that code, > could you fix it to use | instead? > [...]
> And please fix an earlier occurence > of temp16 |= (SPIS_CDS + SPIS_FCERR) as well. Thanks! > Turns out that this is probably better suited for patch 3/11. Regards, Carl-Daniel -- http://www.hailfinger.org/ _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
