On Mon, 13 Jun 2011 23:12:45 +0200 Stefan Tauner <[email protected]> wrote:
> On Mon, 13 Jun 2011 22:09:35 +0200 > Carl-Daniel Hailfinger <[email protected]> wrote: > > > Since you're already changing the function prototype of ich_set_bbar, > > can you make it static? > > > > And another point about the coding style: > > Can you use int bbar_offs instead of void *bbar_addr? > > That way, it is easier to check directly which physmap region the > > accesses correspond to. > > like so? and: - ichspi_bbar = mmio_readl(ich_spibar + bbar_off); + ichspi_bbar = mmio_readl(ich_spibar + bbar_off) & BBAR_MASK; at the end else we would use the reserved bits too -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
