On Sat, May 15, 2010 at 12:29:18AM +0200, Carl-Daniel Hailfinger wrote: > >>>> Look at the return value of wait_82802ab() > >>>> Index: sst49lfxxxc.c > >>>> =================================================================== > >>>> --- sst49lfxxxc.c (revision 993) > >>>> +++ sst49lfxxxc.c (working copy) > >>>> @@ -84,6 +84,7 @@ > >>>> chip_writeb(0xD0, bios + address); > >>>> > >>>> status = wait_82802ab(bios); > >>>> + print_status_82802ab(status); > >>>> > >>>> > >> [...] > >> basically a good idea, but printing one status dump per erased block > >> seems a bit excessive, even in verbose mode, as there are some chips > >> with 4K sector size. Could you limit status printing to "status != > >> 0x80", as this is "ready, no error bits"? > >> > > That's what the 82802ab and sharp lhf00l04 do, too. So if you think the > > behavior should be changed, you should change it in all three places. > > That's the plan.
In the mean-time I guess we can get this in (r1347), if only to reduce the patch queue size. Uwe. -- http://hermann-uwe.de | http://sigrok.org http://randomprojects.org | http://unmaintained-free-software.org _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
