On Fri, 01 Jul 2011 01:21:33 +0200 Carl-Daniel Hailfinger <[email protected]> wrote:
> Am 28.06.2011 05:33 schrieb Stefan Tauner: > > Signed-off-by: Stefan Tauner <[email protected]> > > > > Makes sense, but I worry that this might eventually break something. Do > we (want to) report the inital address setting during programmer init, > especially the reserved bits? we do the usual register dumping for SPIA on ICH7 and VIA, but we dont print the equivalent FADDR in the ICH9 branch. patch appended. > > Anyway, this is > Acked-by: Carl-Daniel Hailfinger <[email protected]> thanks, r1362 -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner
>From dd7d6b461a627fd34c365a3ab6e127a78e97443b Mon Sep 17 00:00:00 2001 From: Stefan Tauner <[email protected]> Date: Fri, 1 Jul 2011 02:50:57 +0200 Subject: [PATCH] ichspi.c: add init printing for FADDR We print the address registers for ICH7 and VIA at init. We should do so for ICH9 too. Signed-off-by: Stefan Tauner <[email protected]> --- ichspi.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/ichspi.c b/ichspi.c index 19e52d2..99c4613 100644 --- a/ichspi.c +++ b/ichspi.c @@ -1288,6 +1288,8 @@ int ich_init_spi(struct pci_dev *dev, uint32_t base, void *rcrb, msg_pdbg("0x06: 0x%04x (HSFC)\n", tmp2); prettyprint_ich9_reg_hsfc(tmp2); + tmp = mmio_readl(ich_spibar + ICH9_REG_FADDR); + msg_pdbg("0x08: 0x%08x (FADDR)\n", tmp); tmp = mmio_readl(ich_spibar + ICH9_REG_FRAP); msg_pdbg("0x50: 0x%08x (FRAP)\n", tmp); msg_pdbg("BMWAG 0x%02x, ", ICH_BMWAG(tmp)); -- 1.7.1
_______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
