On Sun, 24 Jul 2011 20:47:12 +0200 Michael Karcher <[email protected]> wrote:
> The usage of the GPIO output register as bitmap can be confirmed from the > vendor board enable code, so the comment has been deleted. It really is > (1<<gpionumber). > > lspci: http://paste.flashrom.org/view.php?id=729 > superiotool: http://paste.flashrom.org/view.php?id=730 > > Signed-off-by: Michael Karcher <[email protected]> since it has apparently worked (http://paste.flashrom.org/view.php?id=733) and looks fine otherwise, this is Acked-by: Stefan Tauner <[email protected]> two minor nitpicks: > + {0x1039, 0x0651, 0x1039, 0x0651, 0x1039, 0x7012, 0x1458, 0xa002, > "^GA-8SIMLH$",NULL, NULL, P3, "GIGABYTE", "GA-8SIMLH", > 0, OK, sis_gpio0_raise_and_w836xx_memw}, the second device is the sound card, which could presumably be disabled. there is only one other device with a gigabyte vendor id: 1458:5004 (usb2.0 controller). not sure if that would be better, just wanted to mention it. > B("GIGABYTE", "GA-8IRML", 1, > "http://www.gigabyte.com/products/product-page.aspx?pid=1343";, NULL), > + B("GIGABYTE", "GA-8SIMLH", 1, > "http://www.gigabyte.com/products/product-page.aspx?pid=1399";, NULL), > B("GIGABYTE", "GA-8PE667 Ultra 2", 1, > "http://www.gigabyte.com/products/product-page.aspx?pid=1607";, NULL), P < S, so the new one should be below the GA-8PE667. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
