Author: stefanct
Date: Mon Jul 25 22:38:52 2011
New Revision: 1386
URL: http://flashrom.org/trac/flashrom/changeset/1386

Log:
add a bunch of new/tested stuff and various small changes 5

- mark EN25F80 as fully tested
  http://www.flashrom.org/pipermail/flashrom/2011-July/007329.html
- mark W25Q16 as fully tested
  http://www.flashrom.org/pipermail/flashrom/2011-July/007151.html
- mark W39V040A as fully tested
  http://www.flashrom.org/pipermail/flashrom/2011-July/007161.html
- mark Pm25LV040 as fully tested
  reported by TL1 on IRC
- mark W49F002U/N as fully tested
  http://paste.flashrom.org/view.php?id=733g
- mark W39V080FA as fully tested
  http://www.flashrom.org/pipermail/flashrom/2011-July/007225.html

- add ASUS P4S533-X to the list of supported boards
  http://www.flashrom.org/pipermail/flashrom/2011-July/007200.html
- add ASUS M4A785TD-V EVO to the list of supported boards
  http://www.flashrom.org/pipermail/flashrom/2011-July/007329.html
- add GA-945PL-S3P (rev. 6.6) to the list of supported boards
  reported by TL1 on IRC
- add MS-7142 (K8MM-V) to the list of supported boards
  http://www.flashrom.org/pipermail/flashrom/2011-July/007161.html
- add MS-7369 (K9N Neo V2) to the list of supported boards
  http://www.flashrom.org/pipermail/flashrom/2011-July/007181.html
- add X7DBT-INF to the list of supported boards
  http://www.flashrom.org/pipermail/flashrom/2011-July/007225.html

- mark SiS 645DX chipset enable as OK
  http://www.flashrom.org/pipermail/flashrom/2011-July/007200.html
- mark SiS 651 chipset enable as OK
  http://paste.flashrom.org/view.php?id=733

- move intel_ich_gpio34_raise to the correct line(s)
- change the output of unlock_w39_fwh_block from 0x%x to 0x%08x
- fix output for untested chipset enables (missing space)
- reorder the board enable in print.c entry for GA-8SIMLH added in r1385.
- minor other fixes

- fix output for multiple found flash chips by adding quotes and commas
- similarly fix output of "Found/Assuming" chips

Signed-off-by: Stefan Tauner <[email protected]>
the last two points are
Acked-by: Carl-Daniel Hailfinger <[email protected]>
everything else is
Acked-by: Stefan Tauner <[email protected]>

Modified:
   trunk/board_enable.c
   trunk/chipset_enable.c
   trunk/cli_classic.c
   trunk/flashchips.c
   trunk/flashrom.c
   trunk/print.c
   trunk/w39.c

Modified: trunk/board_enable.c
==============================================================================
--- trunk/board_enable.c        Mon Jul 25 19:25:24 2011        (r1385)
+++ trunk/board_enable.c        Mon Jul 25 22:38:52 2011        (r1386)
@@ -1475,15 +1475,6 @@
 
 /*
  * Suited for:
- *  - ASUS A8Jm (laptop): Intel 945 + ICH7
- */
-static int intel_ich_gpio34_raise(void)
-{
-       return intel_ich_gpio_set(34, 1);
-}
-
-/*
- * Suited for:
  *  - MSI MS-7046: LGA775 + 915P + ICH6
  */
 static int intel_ich_gpio19_raise(void)
@@ -1521,6 +1512,15 @@
 
 /*
  * Suited for:
+ *  - ASUS A8Jm (laptop): Intel 945 + ICH7
+ */
+static int intel_ich_gpio34_raise(void)
+{
+       return intel_ich_gpio_set(34, 1);
+}
+
+/*
+ * Suited for:
  *  - ASUS M6Ne (laptop): socket 479M (guessed) + Intel 855PM + ICH4-M
  */
 static int intel_ich_gpio43_raise(void)
@@ -2035,8 +2035,8 @@
        {0x1106, 0x0686, 0x1106, 0x0686,  0x1106, 0x3058, 0x1458, 0xa000, NULL, 
        NULL, NULL,           P3, "GIGABYTE",    "GA-7ZM",                512, 
OK, NULL},
        {0x8086, 0x2570, 0x1458, 0x2570,  0x8086, 0x24d0,      0,      0, 
"^8IP775/-G$",NULL, NULL,           P3, "GIGABYTE",    "GA-8IP775",             
0,   OK, intel_ich_gpio32_raise},
        {0x8086, 0x244b, 0x8086, 0x2442,  0x8086, 0x2445, 0x1458, 0xa002, NULL, 
        NULL, NULL,           P3, "GIGABYTE",    "GA-8IRML",              0,   
OK, intel_ich_gpio25_raise},
-       {0x1039, 0x0651, 0x1039, 0x0651,  0x1039, 0x7002, 0x1458, 0x5004, 
"^GA-8SIMLH$",NULL, NULL,           P3, "GIGABYTE",    "GA-8SIMLH",             
0,   OK, sis_gpio0_raise_and_w836xx_memw},
        {0x8086, 0x24c3, 0x1458, 0x24c2,  0x8086, 0x24cd, 0x1458, 0x5004, NULL, 
        NULL, NULL,           P3, "GIGABYTE",    "GA-8PE667 Ultra 2",     0,   
OK, intel_ich_gpio32_raise},
+       {0x1039, 0x0651, 0x1039, 0x0651,  0x1039, 0x7002, 0x1458, 0x5004, 
"^GA-8SIMLH$",NULL, NULL,           P3, "GIGABYTE",    "GA-8SIMLH",             
0,   OK, sis_gpio0_raise_and_w836xx_memw},
        {0x10DE, 0x02F1, 0x1458, 0x5000,  0x10DE, 0x0261, 0x1458, 0x5001, NULL, 
        NULL, NULL,           P3, "GIGABYTE",    "GA-K8N51GMF",           0,   
OK, nvidia_mcp_gpio3b_raise},
        {0x10DE, 0x026C, 0x1458, 0xA102,  0x10DE, 0x0260, 0x1458, 0x5001, NULL, 
        NULL, NULL,           P3, "GIGABYTE",    "GA-K8N51GMF-9",         0,   
OK, nvidia_mcp_gpio3b_raise},
        {0x10de, 0x00e4, 0x1458, 0x0c11,  0x10de, 0x00e0, 0x1458, 0x0c11, NULL, 
        NULL, NULL,           P3, "GIGABYTE",    "GA-K8NS Pro-939",       0,   
NT, nvidia_mcp_gpio0a_raise},

Modified: trunk/chipset_enable.c
==============================================================================
--- trunk/chipset_enable.c      Mon Jul 25 19:25:24 2011        (r1385)
+++ trunk/chipset_enable.c      Mon Jul 25 22:38:52 2011        (r1386)
@@ -1031,10 +1031,10 @@
        {0x1039, 0x0635, NT, "SiS", "635",              enable_flash_sis540},
        {0x1039, 0x0640, NT, "SiS", "640",              enable_flash_sis540},
        {0x1039, 0x0645, NT, "SiS", "645",              enable_flash_sis540},
-       {0x1039, 0x0646, NT, "SiS", "645DX",            enable_flash_sis540},
+       {0x1039, 0x0646, OK, "SiS", "645DX",            enable_flash_sis540},
        {0x1039, 0x0648, NT, "SiS", "648",              enable_flash_sis540},
        {0x1039, 0x0650, NT, "SiS", "650",              enable_flash_sis540},
-       {0x1039, 0x0651, NT, "SiS", "651",              enable_flash_sis540},
+       {0x1039, 0x0651, OK, "SiS", "651",              enable_flash_sis540},
        {0x1039, 0x0655, NT, "SiS", "655",              enable_flash_sis540},
        {0x1039, 0x0661, OK, "SiS", "661",              enable_flash_sis540},
        {0x1039, 0x0730, NT, "SiS", "730",              enable_flash_sis540},
@@ -1229,7 +1229,7 @@
                msg_pinfo("Found chipset \"%s %s\"",
                          chipset_enables[i].vendor_name,
                          chipset_enables[i].device_name);
-               msg_pdbg("with PCI ID %04x:%04x",
+               msg_pdbg(" with PCI ID %04x:%04x",
                         chipset_enables[i].vendor_id,
                         chipset_enables[i].device_id);
                msg_pinfo(". ");

Modified: trunk/cli_classic.c
==============================================================================
--- trunk/cli_classic.c Mon Jul 25 19:25:24 2011        (r1385)
+++ trunk/cli_classic.c Mon Jul 25 22:38:52 2011        (r1386)
@@ -380,9 +380,10 @@
        }
 
        if (chipcount > 1) {
-               printf("Multiple flash chips were detected:");
-               for (i = 0; i < chipcount; i++)
-                       printf(" %s", flashes[i].name);
+               printf("Multiple flash chips were detected: \"%s\"",
+                       flashes[0].name);
+               for (i = 1; i < chipcount; i++)
+                       printf(", \"%s\"", flashes[i].name);
                printf("\nPlease specify which chip to use with the -c 
<chipname> option.\n");
                ret = 1;
                goto out_shutdown;

Modified: trunk/flashchips.c
==============================================================================
--- trunk/flashchips.c  Mon Jul 25 19:25:24 2011        (r1385)
+++ trunk/flashchips.c  Mon Jul 25 22:38:52 2011        (r1386)
@@ -3075,7 +3075,7 @@
                .total_size     = 1024,
                .page_size      = 256,
                .feature_bits   = FEATURE_WRSR_WREN,
-               .tested         = TEST_OK_PRE,
+               .tested         = TEST_OK_PREW,
                .probe          = probe_spi_rdid,
                .probe_timing   = TIMING_ZERO,
                .block_erasers  =
@@ -5047,7 +5047,7 @@
                .model_id       = PMC_PM25LV040,
                .total_size     = 512,
                .page_size      = 256,
-               .tested         = TEST_UNTESTED,
+               .tested         = TEST_OK_PREW,
                .probe          = probe_spi_rdid,
                .probe_timing   = TIMING_ZERO,
                .block_erasers  =
@@ -7878,7 +7878,7 @@
                .total_size     = 2048,
                .page_size      = 256,
                .feature_bits   = FEATURE_WRSR_WREN,
-               .tested         = TEST_UNTESTED,
+               .tested         = TEST_OK_PREW,
                .probe          = probe_spi_rdid,
                .probe_timing   = TIMING_ZERO,
                .block_erasers  =
@@ -8384,9 +8384,9 @@
                .total_size     = 512,
                .page_size      = 64 * 1024,
                .feature_bits   = FEATURE_EITHER_RESET,
-               .tested         = TEST_OK_PR,
+               .tested         = TEST_OK_PREW,
                .probe          = probe_jedec,
-               .probe_timing   = 10, 
+               .probe_timing   = 10,
                .block_erasers  =
                {
                        {
@@ -8585,7 +8585,7 @@
                .total_size     = 256,
                .page_size      = 128,
                .feature_bits   = FEATURE_EITHER_RESET,
-               .tested         = TEST_OK_PRE,
+               .tested         = TEST_OK_PREW,
                .probe          = probe_jedec,
                .probe_timing   = 10,
                .block_erasers  =
@@ -8705,7 +8705,7 @@
                .total_size     = 1024,
                .page_size      = 64 * 1024,
                .feature_bits   = FEATURE_REGISTERMAP | FEATURE_EITHER_RESET,
-               .tested         = TEST_OK_PRE,
+               .tested         = TEST_OK_PREW,
                .probe          = probe_jedec,
                .probe_timing   = 10,
                .block_erasers  =

Modified: trunk/flashrom.c
==============================================================================
--- trunk/flashrom.c    Mon Jul 25 19:25:24 2011        (r1385)
+++ trunk/flashrom.c    Mon Jul 25 22:38:52 2011        (r1386)
@@ -1201,7 +1201,7 @@
                snprintf(location, sizeof(location), "on %s", 
programmer_table[programmer].name);
 
        tmp = flashbuses_to_text(flash->bustype);
-       msg_cinfo("%s chip \"%s %s\" (%d kB, %s) %s.\n",
+       msg_cinfo("%s %s flash chip \"%s\" (%d kB, %s) %s.\n",
                  force ? "Assuming" : "Found", fill_flash->vendor,
                  fill_flash->name, fill_flash->total_size, tmp, location);
        free(tmp);
@@ -1711,7 +1711,7 @@
                ret = 1;
        }
        /* It would be favorable if we could also check for correct terminaion
-        * of the follwing arrays, but we don't know their size in here...
+        * of the following arrays, but we don't know their sizes in here...
         * For 'flashchips' we check the first element to be non-null. In the
         * other cases there exist use cases where the first element can be
         * null. */

Modified: trunk/print.c
==============================================================================
--- trunk/print.c       Mon Jul 25 19:25:24 2011        (r1385)
+++ trunk/print.c       Mon Jul 25 22:38:52 2011        (r1386)
@@ -448,6 +448,7 @@
        B("ASUS",       "M3A76-CM",             1, 
"http://www.asus.com/product.aspx?P_ID=aU8effdifLvraVze";, NULL),
        B("ASUS",       "M3A78-EM",             1, 
"http://www.asus.com/product.aspx?P_ID=KjpYqzmAd9vsTM2D";, NULL),
        B("ASUS",       "M4A78-EM",             1, 
"http://www.asus.com/product.aspx?P_ID=0KyowHKUFAQqH2DO";, NULL),
+       B("ASUS",       "M4A785TD-V EVO",       1, 
"http://www.asus.com/product.aspx?P_ID=fcsXWSxnhzZE9rnR";, NULL),
        B("ASUS",       "M4A785TD-M EVO",       1, 
"http://www.asus.com/product.aspx?P_ID=QHbvGVB1mXmmD8qQ";, NULL),
        B("ASUS",       "M4A79T Deluxe",        1, 
"http://www.asus.com/product.aspx?P_ID=lhJiLTN5huPfCVkW";, NULL),
        B("ASUS",       "M4A87TD/USB3",         1, 
"http://www.asus.com/product.aspx?P_ID=nlWYrI9wlNIYHAaa";, NULL),
@@ -470,13 +471,14 @@
        B("ASUS",       "P4P800-E Deluxe",      1, 
"http://www.asus.com/product.aspx?P_ID=INIJUvLlif7LHp3g";, NULL),
        B("ASUS",       "P4SC-E",               1, 
"ftp://ftp.asus.com.tw/pub/ASUS/mb/sock478/p4sc-e/";, "Part of ASUS Terminator 
P4 533 barebone system"),
        B("ASUS",       "P4SD-LA",              1, 
"http://h10025.www1.hp.com/ewfrf/wc/document?docname=c00022505";, NULL),
+       B("ASUS",       "P4S533-X",             1, 
"ftp://ftp.asus.com.tw/pub/ASUS/mb/sock478/p4s533-x/";, NULL),
        B("ASUS",       "P4S800-MX",            1, 
"http://www.asus.com/product.aspx?P_ID=Bb57zoJhmO1Qkcrh";, NULL),
        B("ASUS",       "P5A",                  1, 
"ftp://ftp.asus.com.tw/pub/ASUS/mb/sock7/ali/p5a/";, NULL),
        B("ASUS",       "P5B",                  1, 
"ftp://ftp.asus.com.tw/pub/ASUS/mb/socket775/P5B/";, NULL),
        B("ASUS",       "P5B-Deluxe",           1, 
"http://www.asus.com/product.aspx?P_ID=bswT66IBSb2rEWNa";, NULL),
        B("ASUS",       "P5BV-M",               0, 
"ftp://ftp.asus.com.tw/pub/ASUS/mb/socket775/P5B-VM/";, "Reported by Bernhard M. 
Wiedemann <[email protected]> to [email protected], no public archive. 
Missing board enable and/or SST49LF008A unlocking. May work now."),
        B("ASUS",       "P5GC-MX/1333",         1, 
"http://www.asus.com/product.aspx?P_ID=PYvbfOokwxUzJky3";, NULL),
-       B("ASUS",       "P5GDC Deluxe",         1, 
"http://www.asus.com/product.aspx?P_ID=AbeoopyNpI2TZixg";, NULL),
+       B("ASUS",       "P5GDC Deluxe",         1, 
"http://www.asus.com/product.aspx?P_ID=AbeoopyNpI2TZixg";, NULL),
        B("ASUS",       "P5KC",                 1, 
"http://www.asus.com/product.aspx?P_ID=fFZ8oUIGmLpwNMjj";, NULL),
        B("ASUS",       "P5L-MX",               1, 
"http://www.asus.com/product.aspx?P_ID=X70d3NCzH2DE9vWH";, NULL),
        B("ASUS",       "P5GD1 Pro",            1, 
"http://www.asus.com/product.aspx?P_ID=50M49xQh71EZOeM1";, NULL),
@@ -534,8 +536,9 @@
        B("GIGABYTE",   "GA-7ZM",               1, 
"http://www.gigabyte.com/products/product-page.aspx?pid=1366";, "Works fine if 
you remove jumper JP9 on the board and disable the flash protection BIOS 
option."),
        B("GIGABYTE",   "GA-8IP775",            1, 
"http://www.gigabyte.com/products/product-page.aspx?pid=1830";, NULL),
        B("GIGABYTE",   "GA-8IRML",             1, 
"http://www.gigabyte.com/products/product-page.aspx?pid=1343";, NULL),
-       B("GIGABYTE",   "GA-8SIMLH",            1, 
"http://www.gigabyte.com/products/product-page.aspx?pid=1399";, NULL),
        B("GIGABYTE",   "GA-8PE667 Ultra 2",    1, 
"http://www.gigabyte.com/products/product-page.aspx?pid=1607";, NULL),
+       B("GIGABYTE",   "GA-8SIMLH",            1, 
"http://www.gigabyte.com/products/product-page.aspx?pid=1399";, NULL),
+       B("GIGABYTE",   "GA-945PL-S3P (rev. 6.6)", 1, 
"http://www.gigabyte.com/products/product-page.aspx?pid=2541";, NULL),
        B("GIGABYTE",   "GA-965GM-S2 (rev. 2.0)", 1, 
"http://www.gigabyte.com/products/product-page.aspx?pid=2617";, NULL),
        B("GIGABYTE",   "GA-965P-DS4",          1, 
"http://www.gigabyte.com/products/product-page.aspx?pid=2288";, NULL),
        B("GIGABYTE",   "GA-EP35-DS3L",         1, 
"http://www.gigabyte.com/products/product-page.aspx?pid=2778";, NULL),
@@ -602,6 +605,7 @@
        B("MSI",        "MS-7061 (KM3M-V/KM4M-V/KM4AM-V)", 1, 
"http://www.msi.com/service/search/?kw=7061&type=product";, NULL),
        B("MSI",        "MS-7065",              1, 
"http://browse.geekbench.ca/geekbench2/view/53114";, NULL),
        B("MSI",        "MS-7135 (K8N Neo3)",   1, 
"http://www.msi.com/product/mb/K8N-Neo3.html";, NULL),
+       B("MSI",        "MS-7142 (K8MM-V)",     1, 
"http://www.msi.com/product/mb/K8MM-V.html";, NULL),
        B("MSI",        "MS-7168 (Orion)",      1, 
"http://support.packardbell.co.uk/uk/item/index.php?i=spec_orion&pi=platform_honeymoon_istart";,
 NULL),
        B("MSI",        "MS-7207 (K8NGM2-L)",   1, 
"http://www.msi.com/product/mb/K8NGM2-FID--IL--L.html";, NULL),
        B("MSI",        "MS-7211 (PM8M3-V)",    1, 
"http://www.msi.com/product/mb/PM8M3-V.html";, NULL),
@@ -612,6 +616,7 @@
        B("MSI",        "MS-7312 (K9MM-V)",     1, 
"http://www.msi.com/product/mb/K9MM-V.html";, NULL),
        B("MSI",        "MS-7345 (P35 Neo2-FIR)", 1, 
"http://www.msi.com/product/mb/P35-Neo2-FR---FIR.html";, NULL),
        B("MSI",        "MS-7368 (K9AG Neo2-Digital)", 1, 
"http://www.msi.com/product/mb/K9AG-Neo2-Digital.html";, NULL),
+       B("MSI",        "MS-7369 (K9N Neo V2)", 1, 
"http://www.msi.com/product/mb/K9N-Neo-V2.html";, NULL),
        B("MSI",        "MS-7376 (K9A2 Platinum V1)", 1, 
"http://www.msi.com/product/mb/K9A2-Platinum.html";, NULL),
        B("MSI",        "MS-7529 (G31M3-L(S) V2)", 1, 
"http://www.msi.com/product/mb/G31M3-L-V2---G31M3-LS-V2.html";, NULL),
        B("MSI",        "MS-7529 (G31TM-P21)",  1, 
"http://www.msi.com/product/mb/G31TM-P21.html";, NULL),
@@ -648,6 +653,7 @@
        B("Sun",        "Fire x4600",           0, 
"http://www.sun.com/servers/x64/x4600/";, "No public report found. May work 
now."),
        B("Supermicro", "H8QC8",                1, 
"http://www.supermicro.com/Aplus/motherboard/Opteron/nforce/H8QC8.cfm";, NULL),
        B("Supermicro", "X5DP8-G2",             1, 
"http://www.supermicro.com/products/motherboard/Xeon/E7501/X5DP8-G2.cfm";, NULL),
+       B("Supermicro", "X7DBT-INF",            1, 
"http://www.supermicro.com/products/motherboard/Xeon1333/5000P/X7DBT-INF.cfm";, 
NULL),
        B("Supermicro", "X7SPA-HF",             1, 
"http://www.supermicro.com/products/motherboard/ATOM/ICH9/X7SPA.cfm?typ=H&IPMI=Y";,
 NULL),
        B("Supermicro", "X8DT3",                1, 
"http://www.supermicro.com/products/motherboard/QPI/5500/X8DT3.cfm";, NULL),
        B("Supermicro", "X8DTH-6F",             1, 
"http://www.supermicro.com/products/motherboard/QPI/5500/X8DTH-6F.cfm";, NULL),

Modified: trunk/w39.c
==============================================================================
--- trunk/w39.c Mon Jul 25 19:25:24 2011        (r1385)
+++ trunk/w39.c Mon Jul 25 22:38:52 2011        (r1386)
@@ -70,10 +70,10 @@
        if (locking & ((1 << 2) | (1 << 0))) {
                /* Lockdown active? */
                if (locking & (1 << 1)) {
-                       msg_cerr("Can't unlock block at 0x%x!\n", offset);
+                       msg_cerr("Can't unlock block at 0x%08x!\n", offset);
                        return -1;
                } else {
-                       msg_cdbg("Unlocking block at 0x%x\n", offset);
+                       msg_cdbg("Unlocking block at 0x%08x\n", offset);
                        chip_writeb(0, wrprotect);
                }
        }

_______________________________________________
flashrom mailing list
[email protected]
http://www.flashrom.org/mailman/listinfo/flashrom

Reply via email to