On Thu, 28 Jul 2011 10:13:25 +0200
repository service <[email protected]> wrote:

> -     int i;
>       char *idsel = NULL;
> -     int tmp;
> -     int max_decode_fwh_idsel = 0;
> -     int max_decode_fwh_decode = 0;
> +     int i, tmp, max_decode_fwh_idsel = 0, max_decode_fwh_decode = 0;

this kind of mixing declarations with and without initializations is
awful imho. i don't like multiple variables in one declaration except
for simple counters etc, but this is even worse...
</my 2 ct>

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner

_______________________________________________
flashrom mailing list
[email protected]
http://www.flashrom.org/mailman/listinfo/flashrom

Reply via email to