On Wed, 03 Aug 2011 09:02:52 +0200 Carl-Daniel Hailfinger <[email protected]> wrote:
> Suggestion: > struct board_pciid_enable -> struct board_match > board_match_coreboot_name() -> board_match_cbname() > > What do you think? looks fine imo. board_match_pci_card_ids could also be renamed to board_match_pci_ids and if you are at it please change the comment of it: /* * Match boards on PCI IDs and subsystem IDs. * Second set of IDs can be main only or missing completely. */ const static struct board_pciid_enable *board_match_pci_card_ids(enum board_match_phase phase) - * Second set of IDs can be main only or missing completely. + * Second set of IDs can contain primary IDs only or be missing completely. aaaand if we change board_match_pci_card_ids we should also change pci_card_find to pci_dev_find or something like that... :) and now i better stop looking for such stuff. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
