Hi, On Sun, Aug 14, 2011 at 02:50:38AM +0200, Carl-Daniel Hailfinger wrote: > Excellent work! > > The LH28F008BJT patch is > Acked-by: Carl-Daniel Hailfinger <[email protected]>
This was r1420. > The Am29LV008BB patch is > Acked-by: Carl-Daniel Hailfinger <[email protected]> This was r1421. > The PPC patch itself needs more work: > - We need to match the chipset/machine somehow to avoid disasters on > untested machines. While that may not be 100% required, I'm wary of > bricked machines on an architecture I don't own. > - A chipset match where buses_supported = BUS_PARALLEL is set. > - A chipset match where you check if the flash chip is accessible... > comparing lspci --xxx between flash enabled and flash disabled boots > might shed some light on this. Then again, maybe that setting isn't > visible in PCI space and such a check is futile. > - Side note: Not your fault, but we really need a way for a chipset > enable function to tell internal_init that it should return an error. > Maybe a special return code for a chipset enable? Mattias, can you take a look at the issues above? Is it possible to do such chipset matches etc.? Thanks, Uwe. -- http://hermann-uwe.de | http://sigrok.org http://randomprojects.org | http://unmaintained-free-software.org _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
