On Sat, 3 Sep 2011 17:43:53 +0200 Uwe Hermann <[email protected]> wrote:
> On Mon, Aug 22, 2011 at 01:07:50PM +0200, Stefan Tauner wrote: > > --- > > not sure if this is correct for all execution paths, but it fixes the > > output of a probe on my thinkpad. i have looked a bit around to find > > examples of code that this patch would break and found none though. > > > > without this patch: > > Probing for Spansion S25FL064A, 8192 kB: probe_spi_rdid_generic: id1 0xef, > > id2 0x3017 > > Probing for SST SST25LF040A, 512 kB: Invalid OPCODE 0xab, will not execute. > > > > Probing for SST SST25LF080A, 1024 kB: Invalid OPCODE 0xab, will not execute. > > > > Probing for SST SST25VF010.REMS, 128 kB: Invalid OPCODE 0x90, will not > > execute. > > > > Probing for SST SST25VF016B, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 > > 0x3017 > > > > with this patch: > > Probing for Spansion S25FL064A, 8192 kB: probe_spi_rdid_generic: id1 0xef, > > id2 0x3017 > > Probing for SST SST25LF040A, 512 kB: Invalid OPCODE 0xab, will not execute. > > Probing for SST SST25LF080A, 1024 kB: Invalid OPCODE 0xab, will not execute. > > Probing for SST SST25VF010.REMS, 128 kB: Invalid OPCODE 0x90, will not > > execute. > > Probing for SST SST25VF016B, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 > > 0x3017 > > > > Signed-off-by: Stefan Tauner <[email protected]> > > Untested, but I can't see any obvious problems either. > > Acked-by: Uwe Hermann <[email protected]> ok thanks, i have added it to the upcoming tested_stuff branch (#8). -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
