On Tue, 15 Nov 2011 08:54:23 +0100 Carl-Daniel Hailfinger <[email protected]> wrote:
> The shutdown function still has its own static buffer to allow shutdown > even if memory is tight, but AFAICS that should not be needed because > the buffer can never be too small for shutdown once init is complete. If > you agree with that assessment, I could change the shutdown function to > use the common buffer as well. from a glimpse that's true afaics. the shutdown function is registered after the buffer is set to DEFAULT_BUFSIZE. one would want to assert that this is big enough for the shutdown function to work in general... the grow function does what it says. i have not investigated if the buffer makes sense at all, or if it should by generalized... nevertheless i think it would make sense to implement your proposal before a final review... wont get much messier than it is now i guess :) -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
