Re: [flashrom] [PATCH 1/1] Fix programmer-centric probe (patch v2)

Thu, 22 Dec 2011 06:15:10 -0800 

Am Donnerstag, den 22.12.2011, 08:15 +0100 schrieb Michael Karcher:
> Signed-off-by: Michael Karcher <[email protected]>
self-review :)

> +             while( chipcount < ARRAY_SIZE(flashes) ) {
wrong spacing convention, as Stefan Tauner already pointed out in v1 of
the patch. Fixed locally to
                while (chipcount < ARRAY_SIZE(flashes)) {

>                       startchip = probe_flash(&registered_programmers[j],
> -                                             startchip, &flashes[i], 0);
> +                                             startchip, 
> +                                             &flashes[chipcount], 0);
>                       if (startchip == -1)
> -                             break;
> +                             break;
spaces before tabs. The whitespace change of this line is unintentional.
Fixed locally. The end result is a small and clean patch, replacing only
the bad for loop and using chipcount instead of the local counter i as
index for flashes.

Regards,
  Michael Karcher

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
flashrom mailing list
[email protected]
http://www.flashrom.org/mailman/listinfo/flashrom

Reply via email to