On Sat, 13 Jul 2013 17:36:28 +0200 Carl-Daniel Hailfinger <[email protected]> wrote:
> Am 10.07.2013 21:17 schrieb Stefan Tauner: > > Previously the default implementation was used, which always failed. > > On other systems than the Geode the code is not equal to that anymore, > > but should not explode because setup_cpu_msr() returns an error and > > therefore no other MSR functions should be called. > > > > Signed-off-by: Stefan Tauner <[email protected]> > > Tested-by Leonardo Guardati <[email protected]> > > Acked-by: Stefan Tauner <[email protected]> > > > > Signed-off-by: Stefan Tauner <[email protected]> > > Please kill one of your signoffs. That was git send-mail i think... you can ignore that. > I like the simplification of the previous #ifdef mess. > > Cosmetic suggestions (commit is OK without them as well): > Move the libpayload setup_cpu_msr/cleanup_cpu_msr from the top of the > file down to the block right after libpayload_wrmsr. This has the > advantage of making the msr setup code for libpayload dependent on x86 > instead of having it enabled for all architectures. As discussed... in 3/10. > Add a comment to the OSX MSR functions which mentions that rdmsr/wrmsr > are provided by DirectHW. > > Acked-by: Carl-Daniel Hailfinger <[email protected]> Thanks, r1696. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
